IGNITE-28944 Refactor SecurityBasicPermissionSet - #13424
Open
shishkovilja wants to merge 4 commits into
Open
Conversation
shishkovilja
force-pushed
the
ignite-28944
branch
from
August 1, 2026 15:13
323b663 to
6668733
Compare
Contributor
TCBot Test Analysis
Possible Blockers (0)No blockers found. New Tests (0)No new tests found. |
7 tasks
Possible compatibility issues. Please, check rolling upgrade casesThis PR modifies protected classes (with Order annotation). Affected files:
|
petrov-mg
reviewed
Aug 3, 2026
| } | ||
|
|
||
| /** @param map Map. */ | ||
| @SuppressWarnings("rawtypes") |
Contributor
There was a problem hiding this comment.
Suggested change
| @SuppressWarnings("rawtypes") | |
| @SuppressWarnings({"rawtypes", "unchecked"}) |
| } | ||
|
|
||
| /** @param map Map. */ | ||
| @SuppressWarnings("rawtypes") |
Contributor
There was a problem hiding this comment.
Suggested change
| @SuppressWarnings("rawtypes") | |
| @SuppressWarnings({"rawtypes", "unchecked"}) |
| } | ||
|
|
||
| /** */ | ||
| private void convert() { |
| * @param cachePermissions Cache permissions. | ||
| * @return Map with enum sets of security permissions. | ||
| */ | ||
| public static Map<String, Collection<SecurityPermission>> toEnumSetMap( |
Contributor
There was a problem hiding this comment.
toEnumSetMap -> normalizeValueType?
|
|
||
| /** */ | ||
| private static EnumSet<SecurityPermission> copySafe(Collection<SecurityPermission> col) { | ||
| return col != null ? EnumSet.copyOf(col) : EnumSet.noneOf(SecurityPermission.class); |
Contributor
There was a problem hiding this comment.
We can check if col is instanceof EnumSet<SecurityPermission>
| return upcast(srvcPerms); | ||
| } | ||
|
|
||
| /** @param map Map. */ |
Contributor
There was a problem hiding this comment.
We need something more meaningful here, or we should simply leave it empty.
The same below.
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public void unmarshal(Marshaller marsh, ClassLoader clsLdr) throws IgniteCheckedException { | ||
| // Message framework uses ArrayList for ordinary collectons, so we need convert it explicitly. |
| */ | ||
| static Collection<SecurityPermission> permissions(SecurityPermission... perms) { | ||
| Collection<SecurityPermission> col = U.newHashSet(perms.length); | ||
| static EnumSet<SecurityPermission> permissions(SecurityPermission... perms) { |
Contributor
There was a problem hiding this comment.
It seems that we can drop this method and use EnumSet.of(<permisisons>) instead.
|
|
||
| /** */ | ||
| private static void authorizeAll(IgniteSecurity security, Map<String, Collection<SecurityPermission>> permissions) { | ||
| private static void authorizeAll(IgniteSecurity security, |
Contributor
There was a problem hiding this comment.
No line break is needed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.